From 272aae157eee8628b830cc1818f39c8fa8884e23 Mon Sep 17 00:00:00 2001
From: Mark Felder <feld@feld.me>
Date: Sat, 6 Jul 2024 16:56:49 -0400
Subject: [PATCH] Refactor maybe_handle_group_posts/1

---
 changelog.d/group-repeats.fix         |  1 +
 lib/pleroma/web/activity_pub/utils.ex | 24 ++++++------------------
 2 files changed, 7 insertions(+), 18 deletions(-)
 create mode 100644 changelog.d/group-repeats.fix

diff --git a/changelog.d/group-repeats.fix b/changelog.d/group-repeats.fix
new file mode 100644
index 000000000..d465122dd
--- /dev/null
+++ b/changelog.d/group-repeats.fix
@@ -0,0 +1 @@
+Deactivated groups would still try to repeat a post.
diff --git a/lib/pleroma/web/activity_pub/utils.ex b/lib/pleroma/web/activity_pub/utils.ex
index 797e79dda..6c792804d 100644
--- a/lib/pleroma/web/activity_pub/utils.ex
+++ b/lib/pleroma/web/activity_pub/utils.ex
@@ -939,26 +939,14 @@ def get_existing_votes(actor, %{data: %{"id" => id}}) do
     |> Repo.all()
   end
 
+  @spec maybe_handle_group_posts(Activity.t()) :: :ok
+  @doc "Automatically repeats posts for local group actor recipients"
   def maybe_handle_group_posts(activity) do
     poster = User.get_cached_by_ap_id(activity.actor)
 
-    mentions =
-      activity.data["to"]
-      |> Enum.filter(&(&1 != activity.actor))
-
-    mentioned_local_groups =
-      User.get_all_by_ap_id(mentions)
-      |> Enum.filter(fn user ->
-        user.actor_type == "Group" and
-          user.local and
-          not User.blocks?(user, poster)
-      end)
-
-    mentioned_local_groups
-    |> Enum.each(fn group ->
-      Pleroma.Web.CommonAPI.repeat(activity.id, group)
-    end)
-
-    :ok
+    User.get_recipients_from_activity(activity)
+    |> Enum.filter(&match?("Group", &1.actor_type))
+    |> Enum.reject(&User.blocks?(&1, poster))
+    |> Enum.each(&Pleroma.Web.CommonAPI.repeat(activity.id, &1))
   end
 end