From 3b3e1acfeb1935ebe42a395fb9bb95490d0298e6 Mon Sep 17 00:00:00 2001 From: Babibubebon Date: Thu, 23 Jan 2020 16:19:21 +0900 Subject: [PATCH 1/3] fix query including percent-encoded id --- app/Http/Controllers/ResourceController.php | 7 +++---- app/Http/Middleware/DatasetMiddleware.php | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/Http/Controllers/ResourceController.php b/app/Http/Controllers/ResourceController.php index 181c328..9edee8b 100644 --- a/app/Http/Controllers/ResourceController.php +++ b/app/Http/Controllers/ResourceController.php @@ -25,10 +25,9 @@ class ResourceController extends Controller /** * @param $request - * @param $id * @return \EasyRdf_Graph */ - protected function querySparql($request, $id) + protected function querySparql($request) { $client = new \EasyRdf_Sparql_Client($request->datasetConfig['endpoint']); $query = <<querySparql($request, urldecode($id)); + $graph = $this->querySparql($request); if ($graph->isEmpty()) { abort(404); } @@ -75,7 +74,7 @@ EOT; abort(400); } - $graph = $this->querySparql($request, $id); + $graph = $this->querySparql($request); try { $data = $graph->serialise(substr($ext, 1)); } catch (\EasyRdf_Exception $e) { diff --git a/app/Http/Middleware/DatasetMiddleware.php b/app/Http/Middleware/DatasetMiddleware.php index 537a4ef..1882ed5 100644 --- a/app/Http/Middleware/DatasetMiddleware.php +++ b/app/Http/Middleware/DatasetMiddleware.php @@ -22,7 +22,7 @@ class DatasetMiddleware $datasetName = explode('.', $request->route()[1]['as'])[1]; $currentDatasetConfig = config('datasets.' . $datasetName); - $id = $request->route('id'); + $id = urldecode($request->route('id')); $resourceUri = str_replace('{id}', $id, $currentDatasetConfig['resource_uri']); $dataUri = str_replace('{id}', $id, $currentDatasetConfig['data_uri']); From cb93b40501e536d24f7f9aa81b6ed8faf33f95f0 Mon Sep 17 00:00:00 2001 From: Babibubebon Date: Thu, 23 Jan 2020 16:48:00 +0900 Subject: [PATCH 2/3] Add rdf:type values on head of page --- resources/views/parts/row.blade.php | 6 +++--- resources/views/resource.blade.php | 16 +++++++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/resources/views/parts/row.blade.php b/resources/views/parts/row.blade.php index 4b3a602..2beaf72 100644 --- a/resources/views/parts/row.blade.php +++ b/resources/views/parts/row.blade.php @@ -14,14 +14,14 @@ @foreach($objects as $object)
  • @if($object['type'] === 'uri') - {{ $object['value'] }} + {{ \EasyRdf_Namespace::shorten($object['value']) ?? $object['value'] }} @elseif($object['type'] === 'literal') {{ $object['value'] }} @if(isset($object['lang'])) - {{ '@'.$object['lang'] }} + {{ '@'.$object['lang'] }} @endif @if(isset($object['datatype'])) - ^^{{ \EasyRdf_Namespace::shorten($object['datatype']) ?? $object['datatype'] }} + ^^{{ \EasyRdf_Namespace::shorten($object['datatype']) ?? $object['datatype'] }} @endif @endif
  • diff --git a/resources/views/resource.blade.php b/resources/views/resource.blade.php index 7df10be..a375872 100644 --- a/resources/views/resource.blade.php +++ b/resources/views/resource.blade.php @@ -4,9 +4,19 @@ @endsection @section('content') -
    +

    @yield('title')

    - {{ $primaryTopic }} +
    + {{ $primaryTopic }} +
    + An Entity of Type: +
    +
    -
    + From a224d33996e2e3fb20439cf8a08bab243df5383d Mon Sep 17 00:00:00 2001 From: Babibubebon Date: Thu, 23 Jan 2020 16:50:05 +0900 Subject: [PATCH 3/3] bump version to v1.2.2 --- config/app.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/app.php b/config/app.php index c530c41..4ebd087 100644 --- a/config/app.php +++ b/config/app.php @@ -2,7 +2,7 @@ return [ - 'version' => '1.2.1', + 'version' => '1.2.2', /* |--------------------------------------------------------------------------